support aws_vpc_ipam cascade for easier deletes #23973
Conversation
github-actions
bot
added
documentation
AurelienNober
changed the title
AurelienNober
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @AurelienNober 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
AurelienNober
changed the title
justinretzolk
added
enhancement
There was a problem hiding this comment.
$ export AWS_DEFAULT_REGION=us-east-1
$ export AWS_ALTERNATE_REGION=us-west-2
$ make testacc TESTARGS="-run=TestAccVPCIpam_" PKG_NAME="./internal/service/ec2"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ././internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccVPCIpam_ -timeout 180m
=== RUN TestAccVPCIpam_ByoipIPv6
vpc_byoip_test.go:21: Environment variable IPAM_BYOIP_IPV6_MESSAGE, IPAM_BYOIP_IPV6_SIGNATURE, or IPAM_BYOIP_IPV6_PROVISIONED_CIDR is not set
--- SKIP: TestAccVPCIpam_ByoipIPv6 (0.00s)
=== RUN TestAccVPCIpam_basic
=== PAUSE TestAccVPCIpam_basic
=== RUN TestAccVPCIpam_modify
=== PAUSE TestAccVPCIpam_modify
=== RUN TestAccVPCIpam_cascade
=== PAUSE TestAccVPCIpam_cascade
=== RUN TestAccVPCIpam_tags
=== PAUSE TestAccVPCIpam_tags
=== CONT TestAccVPCIpam_basic
=== CONT TestAccVPCIpam_tags
=== CONT TestAccVPCIpam_cascade
=== CONT TestAccVPCIpam_modify
--- PASS: TestAccVPCIpam_basic (34.73s)
--- PASS: TestAccVPCIpam_cascade (41.33s)
--- PASS: TestAccVPCIpam_tags (55.83s)
--- PASS: TestAccVPCIpam_modify (71.13s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 74.362sLooks good to me after the small update to the change log!
Thanks for the contribution and great work!
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTS=TestAccVPCIpam_ PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run='TestAccVPCIpam_' -timeout 180m
=== RUN TestAccVPCIpam_ByoipIPv6
vpc_byoip_test.go:21: Environment variable IPAM_BYOIP_IPV6_MESSAGE, IPAM_BYOIP_IPV6_SIGNATURE, or IPAM_BYOIP_IPV6_PROVISIONED_CIDR is not set
--- SKIP: TestAccVPCIpam_ByoipIPv6 (0.00s)
=== RUN TestAccVPCIpam_basic
=== PAUSE TestAccVPCIpam_basic
=== RUN TestAccVPCIpam_modify
=== PAUSE TestAccVPCIpam_modify
=== RUN TestAccVPCIpam_cascade
=== PAUSE TestAccVPCIpam_cascade
=== RUN TestAccVPCIpam_tags
=== PAUSE TestAccVPCIpam_tags
=== CONT TestAccVPCIpam_basic
=== CONT TestAccVPCIpam_cascade
--- PASS: TestAccVPCIpam_basic (32.83s)
=== CONT TestAccVPCIpam_tags
--- PASS: TestAccVPCIpam_cascade (57.63s)
=== CONT TestAccVPCIpam_modify
--- PASS: TestAccVPCIpam_tags (50.56s)
--- PASS: TestAccVPCIpam_modify (63.53s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 124.857s
|
@AurelienNober Thanks for the contribution 🎉 👏. |
|
This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #23714